Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cleanup on lifetime scope disposal #807

Closed
tillig opened this issue Oct 28, 2016 · 2 comments
Closed

Improve cleanup on lifetime scope disposal #807

tillig opened this issue Oct 28, 2016 · 2 comments

Comments

@tillig
Copy link
Member

tillig commented Oct 28, 2016

Based on notes in this StackOverflow question, it seems LifetimeScope doesn't clean up after itself as well as it could.

For example, after calling Disposer.Dispose() to clean up IDisposables in the scope, should we also call _sharedInstances.Clear() to remove references from the shared instances?

Are there other places we're inadvertently holding references longer than needed?

@OnurGumus
Copy link

Can we back port this change to 3.5.x as well ? We are waiting .NET Core to be more matured.

@tillig
Copy link
Member Author

tillig commented Nov 23, 2016

@OnurGumus The 4.x series of Autofac is not just for .NET Core. If you want the updates, you'll need to upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants