Schema compiler support for relationship expiration trait #2142
+943
−391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/schema
tstirrat15
approved these changes
Nov 25, 2024
| /** | ||
| * ExpirationTrait is an expiration trait of a relation. | ||
| */ | ||
| message ExpirationTrait {} |
There was a problem hiding this comment.
Is this functionally just a presence/absence marker?
There was a problem hiding this comment.
Currently, yes. We might use it in the future to store additional information for the trait, such as if we add a required range of expirations
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of support for expiration trait: adds support for the new trait in the schema IR, the compiler and the generator