DXCDT-348: Manage ul body in branding resource only if custom domains are set #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 87.11% // Head: 86.99% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
- Coverage 87.11% 86.99% -0.13%
==========================================
Files 42 42
Lines 9192 9202 +10
==========================================
- Hits 8008 8005 -3
- Misses 910 920 +10
- Partials 274 277 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sergiught
force-pushed
the
issue-432/DXCDT-348-ul-branding
branch
from
f561365 to
acd3143
Compare
sergiught
commented
Jan 27, 2023
| d.SetId("") | ||
| return diag.Diagnostics{ | ||
| { | ||
| Severity: diag.Warning, |
There was a problem hiding this comment.
Decided to set this to a warning instead of an error when trying to destroy the auth0_branding resource.
6 tasks
willvedd
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
When no custom domains are set and we are trying to manage the universal login body template we get an error from the api:
Error: 400 Bad Request: This feature requires at least one custom domain to be configured for the tenant..The current logic only checks if a tenant flag is set to true, but that's unfortunately flawed.
In this PR we replace that tenant flag check with checking for available custom domains before managing the universal login template body.
📚 References
🔬 Testing
📝 Checklist