Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for User data_source by email #892

Closed
1 task done
scastrianni opened this issue Dec 4, 2023 · 6 comments · Fixed by #1141
Closed
1 task done

Add support for User data_source by email #892

scastrianni opened this issue Dec 4, 2023 · 6 comments · Fixed by #1141
Assignees
Labels
🌱 feature New feature or request

Comments

@scastrianni
Copy link

Checklist

Describe the problem you'd like to have solved

One of the big reasons to use a data_source is to look up a resource by some human friendly name so that you can then access all of the other properties of that data_source throughout the TF config. If I want to add a role to a user, I must have the role_id and the user_id. I can lookup the role_id by use the role data_source and specifying the role name (a human friendly name) and get the role_id from it. However, that is not the case for a user. To lookup a user_id, I need to know the user_id to use the user data_source. If I know the user_id, then there is no point in using the user data_source. Perhaps this is because the email address of the user is NOT unique. No problem, allow the developer to specifying more than just the email address until there is enough information to get a unique user out of it.

Describe the ideal solution

See above

Alternatives and current workarounds

No response

Additional context

No response

@scastrianni scastrianni added the 🌱 feature New feature or request label Dec 4, 2023
@maikvandergaag
Copy link

Yes please

@duedares-rvj duedares-rvj self-assigned this Jan 30, 2025
@duedares-rvj
Copy link
Member

duedares-rvj commented Jan 30, 2025

@scastrianni @maikvandergaag Apologies for such a delayed response on this.
I understand that the present implementation of retrieving a user via user_id has limitations.

We are exploring to add support for specifying Lucene Syntax to the data-source such that the search can be extended to username, email, connection, phonenumber etc.

Let us know your thoughts on it.
Would that be sufficient to add value to your present implementations?

Thanks

Image

@scastria
Copy link

Sounds good to me.

@duedares-rvj
Copy link
Member

This shall be supported once #1141 is merged.
Thanks @scastria

@maikvandergaag
Copy link

Sounds good to me as well

@duedares-rvj
Copy link
Member

Released as part of v1.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants