Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only send tenant configuration if changed #63

Closed
sergiught opened this issue Feb 21, 2022 · 1 comment · Fixed by #144
Closed

Only send tenant configuration if changed #63

sergiught opened this issue Feb 21, 2022 · 1 comment · Fixed by #144
Labels
🪲 bug Something isn't working resource/auth0_tenant

Comments

@sergiught
Copy link
Contributor

From terraform-provider-auth0 created by willvedd: alexkappa/terraform-provider-auth0#513

Description

Originally spurring from #351 which was closed due to the project migration.

From the OP:

This modification makes it such that tenant setting flags will only be included in the PATCH /api/v2/tenants/settings call if they have changed. This proposed change addresses use cases for Auth0 private cloud and enterprise customers whose tenants do not allow updates of certain tenant settings flags. Even the mere presence of these flags in the API call, irrespective of the values changing or not, will cause the API to return an error response. With these proposed changes, the tenant setting flags will simply be omitted from the API call if unchanged, thus bypassing the issue altogether.

This issue, while appearing to be straightforward, is non-trivial to holistically address. I defer to the comments in #351 for explanation.

This would also fix #160 .

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@sergiught
Copy link
Contributor Author

This was fixed through #144 and it will be available in the next release (eta: Monday).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working resource/auth0_tenant
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant