-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth0_branding_theme
requires all args
#412
Comments
Hey @TiltUp-Rad 👋🏻 Thanks for opening an issue! The provider leverages the Auth0 Management API in order to manage branding themes through e.g. https://auth0.com/docs/api/management/v2#!/Branding/post_branding_theme. As you can see almost all the arguments are required when executing this request. We could however provide sensible defaults within the provider code to be sent to the API, perhaps using the ones available when no branding theme is set. What do you think? 🤔 I'll mark this as a feature request instead as this is not currently a bug. |
hey @sergiught cheers, |
oh someone actually picked it up. you guys are amazing <3 |
Hey @TiltUp-Rad 👋🏻 indeed:) @nialdaly did an awesome contribution 💪🏻 We will be able to merge that in today and cut a release. However instead of
We will have the following as the minimal config
Would this work for your use case? |
yup. that works as well :) |
This is now available within the latest release https://github.com/auth0/terraform-provider-auth0/releases/tag/v0.44.1 :) Thanks again @TiltUp-Rad for raising the issue with us! |
Thanks! @sergiught for your work and guidance on it 😀 |
Checklist
Description
auth0_branding_theme
schema requires all fields (which made me click around manually in the end - I do NOT want to provide all the arguments - auth0 defaults work well for me except a couple of exceptions)meanwhile
auth0_branding
has all fields optional (which is nice and easy to use)Expectation
auth0_branding_theme
fields are optional, just likeauth0_branding
Reproduction
go to
https://registry.terraform.io/providers/auth0/auth0/latest/docs/resources/branding_theme
Auth0 Terraform Provider version
0.40.0
Terraform version
1.3.5
The text was updated successfully, but these errors were encountered: