Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth0_branding_theme: Links restricted to IntType but accepts floats on UI #333

Closed
6 tasks done
pablogamboa opened this issue Sep 29, 2022 · 4 comments
Closed
6 tasks done
Labels

Comments

@pablogamboa
Copy link
Contributor

Checklist

  • I have looked into the README and have not found a suitable solution or answer.
  • I have looked into the documentation and have not found a suitable solution or answer.
  • I have searched the issues and have not found a suitable solution or answer.
  • I have upgraded to the latest version of this provider and the issue still persists.
  • I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • I agree to the terms within the Auth0 Code of Conduct.

Description

While porting some manually-added branding tweaks that a colleague had done, I've realized that the UI and API seemingly accept floats as value in certain places where the terraform provider only accepts ints. For example:

I think this TypeInt should be TypeFloat instead.

Expectation

Certain fields should accept float values, and at the moment is restricted to int only.

Reproduction

Go to the UI, introduce a float size for any of the mentioned attributes. Ensure that if you fetch it manually with the API it comes as a float.

Excerpt of me fetching it via curl

curl -vH "Authorization: Bearer ${TOKEN}" \
  https://foo.eu.auth0.com/api/v2/branding/themes/default
{
"fonts": {
    "font_url": "https://github.com/ethereum/ethdev-site/blob/master/public/fonts/Proxima%20Nova%20Reg%20It.woff",
    "reference_text_size": 16,
    "title": {
      "bold": true,
      "size": 150
    },
    "subtitle": {
      "bold": false,
      "size": 87.5
    },
    "body_text": {
      "bold": false,
      "size": 87.5
    },
    "buttons_text": {
      "bold": true,
      "size": 100
    },
    "input_labels": {
      "bold": false,
      "size": 100
    },
    "links": {
      "bold": true,
      "size": 87.5
    },
    "links_style": "normal"
  },
...
}

Auth0 Terraform Provider version

0.37.1

Terraform version

1.1.4

@pablogamboa pablogamboa added the 🪲 bug Something isn't working label Sep 29, 2022
@thetimbecker
Copy link

I am in the same situation and running into this exact same issue, down to the numbers. I'm assuming these are the default numbers which means this will be a common issue people run into.

As a workaround, I am setting these to 87 instead of 87.5. I'm sure no one will mind.

Also, in case anyone else is stuck on this, I couldn't find the theme ID in the UI. I ended up finding it using the Management API browser: https://auth0.com/docs/api/management/v2/#!/Branding/get_default_branding_theme

@sergiught
Copy link
Contributor

Hey folks, apologies for the inconvenience caused, that was a pretty bad oversight on our part. 😞 We'll probably have some time to focus on fixing this once we wrap up #14. We'll keep you updated 🙏🏻

@sergiught
Copy link
Contributor

Hey folks, we just released https://registry.terraform.io/providers/auth0/auth0/0.39.0 with a fix for this. We'll close the issue down now.

@pablogamboa
Copy link
Contributor Author

@sergiught thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants