Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: install updated saml to address issue with malformed pem #129

Merged
merged 1 commit into from
May 18, 2022
Merged

fix: install updated saml to address issue with malformed pem #129

merged 1 commit into from
May 18, 2022

Conversation

david-renaud-okta
Copy link
Contributor

@david-renaud-okta david-renaud-okta commented May 16, 2022 •
edited
Loading

Description

  • Updated saml library to 3.0.0 to restore behaviour of allowing PEM files with missing newlines

References

https://github.com/auth0/node-saml/releases/tag/v3.0.0

Testing

  • Automated testing passes
  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@david-renaud-okta david-renaud-okta force-pushed the IPS-2562 branch 2 times, most recently from 065ced5 to a1d4c51 Compare May 16, 2022 17:07
@jakelacey2012
Copy link
Contributor

I think we may have to change some of the settings in the repo so that 10.x isn't required so that we can merge this PR.

Screenshot 2022-05-17 at 15 09 22

@david-renaud-okta david-renaud-okta merged commit ce5cb5c into master May 18, 2022
@david-renaud-okta david-renaud-okta deleted the IPS-2562 branch May 18, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomauth0 tomauth0 tomauth0 approved these changes

@jakelacey2012 jakelacey2012 jakelacey2012 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-renaud-okta @jakelacey2012 @tomauth0