Merge pull request #198 from inventage/improve-performance

Instantiate exception only when required
auth0 · Aug 29, 2017 · ba902e9 · ba902e9
2 parents 3f1472f + 804b1bb
commit ba902e9
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/lib/src/main/java/com/auth0/jwt/impl/JWTParser.java b/lib/src/main/java/com/auth0/jwt/impl/JWTParser.java
@@ -49,14 +49,17 @@ static ObjectMapper getDefaultObjectMapper() {
 
     @SuppressWarnings("WeakerAccess")
     <T> T convertFromJSON(String json, Class<T> tClazz) throws JWTDecodeException {
-        JWTDecodeException exception = new JWTDecodeException(String.format("The string '%s' doesn't have a valid JSON format.", json));
         if (json == null) {
-            throw exception;
+            throw exceptionForInvalidJson(null);
         }
         try {
             return mapper.readValue(json, tClazz);
         } catch (IOException e) {
-            throw exception;
+            throw exceptionForInvalidJson(json);
         }
     }
+
+    private JWTDecodeException exceptionForInvalidJson(String json) {
+        return new JWTDecodeException(String.format("The string '%s' doesn't have a valid JSON format.", json));
+    }
 }