Increase test coverage for actions #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
force-pushed
the
patch/DXCDT-408-action-test
branch
from
e103fe4 to
f0e5536
Compare
sergiught
commented
Mar 16, 2023
| @@ -25,7 +25,7 @@ auth0 actions update [flags] | |||
| auth0 actions update <action-id> --name myaction --code "$(cat path/to/code.js)" --dependency "lodash=4.0.0" | |||
| auth0 actions update <action-id> --name myaction --code "$(cat path/to/code.js)" --dependency "lodash=4.0.0" --secret "SECRET=value" | |||
| auth0 actions update <action-id> --name myaction --code "$(cat path/to/code.js)" --dependency "lodash=4.0.0" --dependency "uuid=9.0.0" --secret "API_KEY=value" --secret "SECRET=value" | |||
| auth0 actions update <action-id> -n myaction -t post-login -c "$(cat path/to/code.js)" -d "lodash=4.0.0" -d "uuid=9.0.0" -s "API_KEY=value" -s "SECRET=value" --json | |||
There was a problem hiding this comment.
We can't update the triggers once set, this was flawed within the docs.
Comment on lines
-399
to
-402
| _, err := cli.api.Action.Read(inputs.ID) | ||
| if err != nil { | ||
| return fmt.Errorf("Unable to delete action: %w", err) | ||
| } |
There was a problem hiding this comment.
It didn't make any sense to do a read and then a delete. The delete will throw an error if the action doesn't exist, e.g.
Deleting action... failed
=== example.eu.auth0.com error
▸ 404 Not Found: That action does not exist.
sergiught
force-pushed
the
patch/DXCDT-408-action-test
branch
from
f0e5536 to
41da089
Compare
Widcket
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Mainly expand test coverage on the actions commands, however a couple of modest improvements were made as well. More details below in the comments.
📚 References
🔬 Testing
Commander + unit tests.
📝 Checklist