Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show non-ready custom domains #781

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Show non-ready custom domains #781

merged 6 commits into from
Aug 1, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Jul 25, 2023

🔧 Changes

I was recently working with custom domains, specifically adding and verifying it. I was able to add my custom domain with auth0 domains create. However, when I went to list with auth0 domains list, it stated that there were no custom domains. This is because the Auth0 CLI hides non-ready custom domains. Considering that most (all?) tenants have a limit of one custom domain, there is very little reason to ever hide it if one exists. Especially because it interferes when trying to add and verify a custom domain.

🔬 Testing

Updated unit tests. Manual verification.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner July 25, 2023 16:52
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (2f4e29e) 72.07% compared to head (563d318) 72.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
- Coverage   72.07%   72.07%   -0.01%     
==========================================
  Files          89       89              
  Lines       11156    11155       -1     
==========================================
- Hits         8041     8040       -1     
  Misses       2613     2613              
  Partials      502      502              
Files Changed Coverage Δ
internal/cli/custom_domains.go 78.83% <ø> (-0.07%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willvedd willvedd enabled auto-merge (squash) July 25, 2023 17:20
@willvedd willvedd merged commit 411bcda into main Aug 1, 2023
@willvedd willvedd deleted the list-all-domains branch August 1, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants