Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra headings in apis list #711

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Remove extra headings in apis list #711

merged 1 commit into from
Apr 4, 2023

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Apr 3, 2023

🔧 Changes

This PR fixes an issue where the output of apis list would print the header twice.

Before

Screenshot 2023-04-03 at 8 04 22 PM

After

Screenshot 2023-04-03 at 8 42 36 PM

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@Widcket Widcket requested a review from a team as a code owner April 3, 2023 23:43
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (23bab3c) 65.09% compared to head (410575b) 65.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
+ Coverage   65.09%   65.16%   +0.07%     
==========================================
  Files          87       87              
  Lines       11269    11268       -1     
==========================================
+ Hits         7335     7343       +8     
+ Misses       3419     3410       -9     
  Partials      515      515              
Impacted Files Coverage Δ
internal/display/apis.go 79.69% <ø> (-0.16%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@willvedd willvedd merged commit d72403b into main Apr 4, 2023
@willvedd willvedd deleted the fix/apis-display branch April 4, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants