Leverage the management client to make api requests in api cmd #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
force-pushed
the
patch/api-cmd-retries
branch
from
e0fbf35 to
99aa669
Compare
sergiught
force-pushed
the
patch/api-cmd-retries
branch
from
99aa669 to
0a5e89d
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
==========================================
- Coverage 54.43% 54.38% -0.05%
==========================================
Files 89 89
Lines 11510 11515 +5
==========================================
- Hits 6265 6263 -2
- Misses 4796 4802 +6
- Partials 449 450 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
sergiught
force-pushed
the
patch/api-cmd-retries
branch
from
d607047 to
1d33d27
Compare
sergiught
force-pushed
the
patch/api-cmd-retries
branch
from
1d33d27 to
6af4a7c
Compare
|
Codecov message is outdated: https://app.codecov.io/gh/auth0/auth0-cli/pull/681 this pr increases code coverage by 0.08%. |
Widcket
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This PR changes the internals of the auth0 api command to leverage the already configured Auth0 Go SDK to execute the requests, in order to leverage the retries and access token that is already configured on the client.
📚 References
🔬 Testing
This change is covered by the tests we already have and a few extra ones.
📝 Checklist