Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-405: Fix incorrect number rendered in header for auth0 apps list #674

Merged
merged 22 commits into from
Mar 14, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Mar 13, 2023

🔧 Changes

When running auth0 apps list, the number of apps listed in the header is one higher than the actual number of apps rendered in the output. This is because the global client (mostly deprecated) is included in the header number but is filtered by the output. The fix here is to use the length of the filtered applications to determine the header number instead of the raw number of clients which likely include the deprecated global client.

🔬 Testing

Primarily manual but mostly covered by existing integration tests.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner March 13, 2023 16:37
internal/display/apps.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 54.54% and no project coverage change.

Comparison is base (e10608c) 50.45% compared to head (e3b4f26) 50.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #674   +/-   ##
=======================================
  Coverage   50.45%   50.45%           
=======================================
  Files          93       93           
  Lines       11764    11764           
=======================================
  Hits         5936     5936           
  Misses       5400     5400           
  Partials      428      428           
Impacted Files Coverage Δ
internal/display/apps.go 76.82% <54.54%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@willvedd willvedd enabled auto-merge (squash) March 13, 2023 19:38
@sergiught sergiught disabled auto-merge March 14, 2023 08:18
internal/cli/apps.go Outdated Show resolved Hide resolved
@sergiught sergiught merged commit bc227e4 into main Mar 14, 2023
@sergiught sergiught deleted the DXCDT-405-apps-list-correct-heading-number branch March 14, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants