-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DXCDT-405: Fix incorrect number rendered in header for auth0 apps list
#674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
reviewed
Mar 13, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
=======================================
Coverage 50.45% 50.45%
=======================================
Files 93 93
Lines 11764 11764
=======================================
Hits 5936 5936
Misses 5400 5400
Partials 428 428
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…github.com/auth0/auth0-cli into DXCDT-405-apps-list-correct-heading-number
sergiught
reviewed
Mar 14, 2023
sergiught
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
When running
auth0 apps list
, the number of apps listed in the header is one higher than the actual number of apps rendered in the output. This is because the global client (mostly deprecated) is included in the header number but is filtered by the output. The fix here is to use the length of the filtered applications to determine the header number instead of the raw number of clients which likely include the deprecated global client.🔬 Testing
Primarily manual but mostly covered by existing integration tests.
📝 Checklist