DXCDT-323: Allow updating an email template when it does not exist #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Jan 18, 2023
Widcket
reviewed
Jan 18, 2023
Widcket
approved these changes
Jan 18, 2023
willvedd
reviewed
Jan 18, 2023
Comment on lines
+207
to
+211
| oldTemplate = &management.EmailTemplate{ | ||
| From: auth0.String(""), | ||
| Subject: auth0.String(""), | ||
| Enabled: auth0.Bool(false), | ||
| Syntax: auth0.String("liquid"), |
There was a problem hiding this comment.
Question: Is it necessary to instantiate with empty values here if the emailTemplate gets fully constructed below?
There was a problem hiding this comment.
Sadly yes 😞 as otherwise this line https://github.com/auth0/auth0-cli/pull/611/files#diff-7c49d78e329a015986302ea95a143d68ca7d933a41514ca964b46bddcd22f31aR215 will panic when accessing oldTemplate.From. We can't replace it with the safe access getter GetFrom due to all the prompts using pointers for default values. That should be refactored in a separate dedicated PR IMO.
willvedd
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Previously when trying to update an email template with
auth0 email templates update, if we were to select a template that does not yet exist, we would get back a 404 error. In this PR we're changing the behavior of the command to instead create the template if it does not yet exist improving the DX.📚 References
🔬 Testing
📝 Checklist