DXCDT-326: align --number usage across commands #610
Conversation
| @@ -70,22 +81,38 @@ func listRolePermissionsCmd(cli *cli) *cobra.Command { | |||
| inputs.ID = args[0] | |||
| } | |||
|
|
|||
| var list *management.PermissionList | |||
| list, err := getWithPagination( | |||
There was a problem hiding this comment.
Nit: This change it outside the purview of the PR. It's ok for now, but next time consider separating these changes.
| @@ -628,6 +646,10 @@ func listMembersRolesOrganizationCmd(cli *cli) *cobra.Command { | |||
| auth0 orgs roles members ls <org-id> -r role -n 100 | |||
| auth0 orgs roles members ls <org-id> -r role -n 100 --json`, | |||
| RunE: func(cmd *cobra.Command, args []string) error { | |||
| if inputs.Number < 1 || inputs.Number > 1000 { | |||
There was a problem hiding this comment.
I imagine that you considered separating this into its own separate function. Was the idea here to keep the overhead low?
There was a problem hiding this comment.
I didn't consider moving this validation out, but @sergiught and I did chat about whether we could add a way to provide validation within a Flag struct rather than have the validation logic within the command logic
There was a problem hiding this comment.
whether we could add a way to provide validation within a Flag struct rather than have the validation logic within the command logic
Good idea!
There was a problem hiding this comment.
🤔 Wdyt if we keep the current number validation in this PR to keep things simple, even tho repeated, and follow up with a PR to add a Validation field on the Flag struct?
sergiught
force-pushed
the
DXCDT-326-number
branch
from
01c2697 to
e893024
Compare
Co-authored-by: Sergiu Ghitea <[email protected]>
sergiught
force-pushed
the
DXCDT-326-number
branch
from
e893024 to
7854f8a
Compare
ewanharris
requested review from
willvedd and
sergiught
and removed request for
willvedd and
sergiught
|
Great first contribution 👍🏻 @ewanharris 🥳 |
🔧 Changes
Aligns the usage of the
--numberflag across commands to be consistent and show the relevant description in each help screen📚 References
🔬 Testing
📝 Checklist