Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DXCDT-314: Add ability to remove roles from a user #606

Merged
merged 1 commit into from
Jan 17, 2023
Merged

DXCDT-314: Add ability to remove roles from a user #606

merged 1 commit into from
Jan 17, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Jan 12, 2023 •
edited
Loading

🔧 Changes

Add ability to remove roles from a user.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught self-assigned this Jan 12, 2023
@sergiught sergiught marked this pull request as ready for review January 12, 2023 19:58
@sergiught sergiught requested a review from a team as a code owner January 12, 2023 19:58
Widcket
Widcket reviewed Jan 12, 2023
View reviewed changes
internal/auth0/user.go Outdated Show resolved Hide resolved
willvedd
willvedd reviewed Jan 13, 2023
View reviewed changes
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is a new command, can we add some type of commander test?

@sergiught sergiught marked this pull request as draft January 17, 2023 15:22
@sergiught sergiught force-pushed the feature/DXCDT-314-assign-roles branch from 1f0afc8 to 0f807f2 Compare January 17, 2023 16:18
@sergiught sergiught force-pushed the feature/DXCDT-314-remove-roles branch from 3aea807 to a861d5b Compare January 17, 2023 16:29
Base automatically changed from feature/DXCDT-314-assign-roles to v1 January 17, 2023 16:29
@sergiught sergiught force-pushed the feature/DXCDT-314-remove-roles branch from a861d5b to 3905295 Compare January 17, 2023 16:30
@sergiught sergiught marked this pull request as ready for review January 17, 2023 16:30
@sergiught sergiught requested a review from willvedd January 17, 2023 16:30
willvedd
willvedd approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergiught sergiught merged commit 231ec9b into v1 Jan 17, 2023
@sergiught sergiught deleted the feature/DXCDT-314-remove-roles branch January 17, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket left review comments

@willvedd willvedd willvedd approved these changes

Assignees

@sergiught sergiught

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergiught @willvedd @Widcket