Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-320: Fix management of action triggers #597

Merged
merged 18 commits into from
Jan 11, 2023

Conversation

willvedd
Copy link
Contributor

🔧 Changes

This PR attempts to improve the management of action with regards to triggers. Currently, there are two major issues:

  • When creating actions, the interactive list of action triggers only lists post-login, prohibiting the selection of any other trigger
  • When updating actions, the trigger in most (if not all) cases cannot be updated, with minor exceptions

In the case of action creation, the interactive prompt should display all currently available action triggers. Currently, it only displays post-login erroneously. This was a case of correcting some filtering logic.

In the case of the action update, while it is technically possible to update the trigger in certain cases, the majority of the time the trigger cannot be updated. AFAICT, the guidance for changing a trigger is to create a new action. For this reason, I am proposing to remove the ability to update a trigger. Otherwise, the operation will fail in the majority of cases.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner January 11, 2023 15:30
docs/auth0_actions_update.md Outdated Show resolved Hide resolved
internal/cli/actions.go Outdated Show resolved Hide resolved
@sergiught sergiught merged commit 3bf0f9c into v1 Jan 11, 2023
@sergiught sergiught deleted the DXCDT-320-fix-actions-create-list-all-triggers branch January 11, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants