Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-304: Logs output display absolute time #590

Merged
merged 11 commits into from
Jan 10, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Jan 9, 2023

🔧 Changes

As reported by #418 , the date output in auth0 logs tail is not useful because it displays in relative time (ex: "5 minutes ago"). This is a problem because the logs stream output does not update the rows that have already rendered, meaning that the time displayed is stuck to a moment in the past. Instead, the logs tail output should display absolute time so that the time displayed is never incorrect. Unfortunately, this same logs output is used for the auth0 logs show command, which would not have the same problem as the above. However, it is currently not possible to separate the rendering logic for each command.

📚 References

Original issue: #418

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner January 9, 2023 22:16
@sergiught sergiught merged commit 20ba3df into v1 Jan 10, 2023
@sergiught sergiught deleted the DXCDT-304-logs-tail-absolute-time-displayed branch January 10, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants