DXCDT-307: Fix users search command to correctly search through result pages #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
force-pushed
the
patch/DXCDT-307-users-pagination
branch
from
6accc43 to
217e5dc
Compare
sergiught
force-pushed
the
patch/follow-up-on-docs
branch
from
7c67aff to
e644f30
Compare
sergiught
force-pushed
the
patch/DXCDT-307-users-pagination
branch
from
217e5dc to
d6ec4db
Compare
sergiught
force-pushed
the
patch/DXCDT-307-users-pagination
branch
from
d6ec4db to
e8d3a52
Compare
…' into patch/DXCDT-307-users-pagination
Widcket
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
As mentioned in #485, the users search command only gives back the first 50 results and it doesn't keep looping through the paginated results.
In this PR we are adding a
--numberflag to be consistent with the other list commands and define a total amount of items to return.📚 References
🔬 Testing
📝 Checklist