Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-303: Fix orgs update cmd #583

Merged
merged 5 commits into from
Jan 5, 2023
Merged

DXCDT-303: Fix orgs update cmd #583

merged 5 commits into from
Jan 5, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Jan 5, 2023

🔧 Changes

This PR fixes an issue with the auth0 orgs update cmd where by mistake the payload sent over to the Management API included as well the ID of the organization. This is the same issue as reported in #467.

Furthermore while fixing and testing the update I noticed an issue with the auth0 orgs create cmd as well where we were sending metadata as a null object even when not specified.

📚 References

🔬 Testing

The PR adds additional tests using the commander test file.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught self-assigned this Jan 5, 2023
@sergiught sergiught marked this pull request as ready for review January 5, 2023 13:30
@sergiught sergiught requested a review from a team as a code owner January 5, 2023 13:30
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@sergiught sergiught merged commit abb6b2e into v1 Jan 5, 2023
@sergiught sergiught deleted the patch/DXCDT-303-org-id-bug branch January 5, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants