From 62e123fc87972d61b13f2537e36738416ce59ec4 Mon Sep 17 00:00:00 2001 From: Cyril David Date: Mon, 25 Jan 2021 16:40:21 -0800 Subject: [PATCH] Add a simple unit test to catch regressions --- internal/auth/auth.go | 2 +- internal/auth/auth_test.go | 49 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+), 1 deletion(-) create mode 100644 internal/auth/auth_test.go diff --git a/internal/auth/auth.go b/internal/auth/auth.go index 49afdfff3..0504dd881 100644 --- a/internal/auth/auth.go +++ b/internal/auth/auth.go @@ -43,7 +43,7 @@ var requiredScopes = []string{ "create:hooks", "delete:hooks", "read:hooks", "update:hooks", "create:resource_servers", "delete:resource_servers", "read:resource_servers", "update:resource_servers", "create:rules", "delete:rules", "read:rules", "update:rules", - "read:logs", + "read:client_keys", "read:logs", } type Authenticator struct { diff --git a/internal/auth/auth_test.go b/internal/auth/auth_test.go new file mode 100644 index 000000000..61132d058 --- /dev/null +++ b/internal/auth/auth_test.go @@ -0,0 +1,49 @@ +package auth + +import "testing" + +func TestRequiredScopes(t *testing.T) { + t.Run("verify CRUD", func(t *testing.T) { + crudResources := []string{ + "actions", + "clients", + "connections", + "hooks", + "resource_servers", + "rules", + } + crudPrefixes := []string{"create:", "delete:", "read:", "update:"} + + for _, resource := range crudResources { + for _, prefix := range crudPrefixes { + scope := prefix + resource + + if !strInArray(requiredScopes, scope) { + t.Fatalf("wanted scope: %q, list: %+v", scope, requiredScopes) + } + } + } + }) + + t.Run("verify special scopes", func(t *testing.T) { + list := []string{ + "read:client_keys", "read:logs", + } + + for _, v := range list { + if !strInArray(requiredScopes, v) { + t.Fatalf("wanted scope: %q, list: %+v", v, requiredScopes) + } + } + }) +} + +func strInArray(haystack []string, needle string) bool { + for _, v := range haystack { + if v == needle { + return true + } + } + + return false +}