-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add provideAuth0
method
#444
Comments
Thanks. I do believe providing a However, I am not sure it's a good idea to do so before we are compiling our SDK using Angular 15 (which is expected to happen in november 2023), currently we are using Angular 13. Given the simplicity of our SDK, we aren't compiling a version for every major angular version, instead we are compiling using the lowest supported version of Angular at the moment, which is 13 atm. This has the downside that we have no access to the latest things as soon as they come out. However, if anything would lead to our SDK to become unusable, we will make chances as needed. In this case, I believe it's all just syntactic sugar and there isn't anything limiting you to use our SDK in it's current state. The reason I am saying we want to wait until Angular 15 is because we have no ability to use EnvironmentProviders yet (until we rely on Angular 15 and drop support for anything below Angular 15), which I believe we should include as part of the provideAuth0 method we want to expose, as it's the equivalent of We could already offer a provideAuth0 function today, and ignore the EnvironmentProviders. However, if we would include it once we compile using Angular15, it could be considered a breaking change. Therefore I believe it's better to hold of until we compile using Angular 15. In the meantime, this is how you should be able to use our SDK with Standalone and more functional approaches, with no downsides as far as I am aware: #442 (comment). Having said that, happy to hear anyones opinion. |
Having said all of the above, I opened a draft PR to add support for this as I believe we want to facilitate modern approaches where possible, especially if they are easy to support. When Angular 15 comes out, we plan to add support for EnvironmentProviders, which could break people. @Lonli-Lokli Could you have a look and see if this PR works for you? |
Released as 2.1.0. |
Describe the problem you'd like to have solved
With standalone angular app provideXXX is the best way for importing components during bootstrap to get rid of NgModules.
Describe the ideal solution
new method similar to Auth0.forRoot
Alternatives and current work-arounds
Additional context
The text was updated successfully, but these errors were encountered: