Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closable option has no effect on iPad #658

Closed
agirault opened this issue Feb 23, 2021 · 1 comment
Closed

closable option has no effect on iPad #658

agirault opened this issue Feb 23, 2021 · 1 comment

Comments

@agirault
Copy link
Contributor

Describe the problem

On iPad, the LockViewController is presented as a .formSheet. As such, it can be dismissed by simply tapping outside the bounds of the modal. The closable Lock option has no effect since the modal will be dismissed either way.

What was the expected behavior?

The LockViewController should not be dismissed by tapping outside the modal if closable is set to false (default value).

Reproduction

  1. Set closable option to false (optional, since defaults to false):
.withOptions {
  $0.closable = false
}
  1. Show Lock screen on iPad
  2. Tap outside the presented modal

Can the behavior be reproduced using the included Lock.swift demo app?

Yes

Environment

  • Version of Lock.swift used: 2.16.1
  • Version of iOS: 13.4
  • Version of Xcode: 11.7
@Widcket
Copy link
Contributor

Widcket commented Apr 13, 2021

Fixed by #647

@Widcket Widcket closed this as completed Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants