Ability to access Canvas view without composer.lock file #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow option to work without composer.lock file and use base Composer InstalledVersions method.
|
Didn't know this utility existed. Thanks for the submission @itemshopp! Changed the branch to |
austintoddj
added a commit
that referenced
this pull request
May 24, 2023
|
Added this to the latest release 6.0.46 since I'm not sure when I'm not sure when 7.0 will launch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Canvas::installedVersionmethod uses actuallyfile_get_contentssearching for acomposer.lockfile in project.If no
composer.lockfile, it returns an error making it difficult to access the canvas view.Replacing the actual method lines with the builtin
\Composer\InstalledVersions::getPrettyVersion(...)will find the package version in composer.lock if any, and if not, in the composer.json file.Hope this helps.