Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to save nextcloud source #161

Open
Gene-W opened this issue Apr 28, 2023 · 11 comments
Open

Unable to save nextcloud source #161

Gene-W opened this issue Apr 28, 2023 · 11 comments
Labels
bug Something isn't working
Milestone

Comments

@Gene-W
Copy link

Gene-W commented Apr 28, 2023

Describe the bug
Unable to save subsonic server source

To Reproduce
Steps to reproduce the behavior:

  1. Open Subtracks alpha
  2. Click on 'add source'
  3. Complete source fields; click save
  4. Subtracks stays on 'add source' screen, no other buttons work except back which removes entered information

Expected behavior
After I add my Subsonic server information, source will not save. In previous Subtracks, I had to use 'force plaintext password' and wonder if this is causing my issue.

Smartphone (please complete the following information):

  • Device: OnePlus 6
  • OS: LineageOS 20 / Android 13
  • Subtracks version 2.00-alpha.1

Additional context
Good to see your progress and happy to provide feedback and help in whatever way I'm able!

@Gene-W Gene-W added the bug Something isn't working label Apr 28, 2023
@austinried
Copy link
Owner

I had to use 'force plaintext password' and wonder if this is causing my issue.

Ah yes this is the problem, sorry I should have mentioned that in the release notes. Currently only token authorization is supported, I'll prioritize adding this back for alpha.2

@austinried austinried added this to the 2.0.0 milestone Apr 28, 2023
@austinried austinried changed the title Subtracks version 2.00-alpha.1 Not able to add server with plaintext password auth Apr 28, 2023
@Gene-W
Copy link
Author

Gene-W commented Apr 28, 2023

Ah yes this is the problem, sorry I should have mentioned that in the release notes. Currently only token authorization is supported, I'll prioritize adding this back for alpha.2

Very good, thank you! If there's a way to circumvent the plaintext password I would do it. No time to fiddle with it though, still using original Subtracks until I am able to get in the alpha.

@austinried austinried added enhancement New feature or request and removed bug Something isn't working labels May 6, 2023
@austinried
Copy link
Owner

Just pushed the change to enable the force plaintext password option into main now, this will be in alpha 2 when it goes out soon.

@austinried
Copy link
Owner

The option for plaintext password was released in 2.0.0-alpha.2, feel free to give that version a shot.

@Gene-W
Copy link
Author

Gene-W commented May 8, 2023

Not sure why, but I'm getting the same action, unable to save server. I removed alpha.1 and installed alpha.2, generated a new password in nextcloud music, but it's not saving. 🤔

@austinried
Copy link
Owner

There must be something else going on with the initial test then, I wonder if it has to do with nextcloud specifically. I had a test nextcloud server up and running at one point, I'll see if I can spin it up again and figure out where it's failing.

I'll also be adding proper logging soon so I can get a better idea of what's going on in these situations.

@austinried austinried reopened this May 11, 2023
@austinried austinried changed the title Not able to add server with plaintext password auth Unable to save nextcloud source May 11, 2023
@austinried austinried added bug Something isn't working and removed enhancement New feature or request labels May 11, 2023
@austinried
Copy link
Owner

I haven't gotten around to setting up my nextcloud instance again yet, but I've just pushed a new alpha that contains new error messaging and logging that I think could help show what the problem is here. Would you be able to try this release?

https://github.com/austinried/subtracks/releases/tag/v2.0.0-alpha.3

@jvadair
Copy link

jvadair commented May 16, 2023

I am experiencing the same issue on alpha.3.
Specifically, SubsonicException [41]: Token-based authentication not supported

Nextcloud version: 23.0.12
Connection details:

  • HTTPS/secure
  • flipping the plaintext password switch does not affect the issue

@Gene-W
Copy link
Author

Gene-W commented May 17, 2023

@austinried the error @jvadair posted is exactly what I'm getting as well.

@austinried
Copy link
Owner

Thanks for the update, I think I've found the issue:

flipping the plaintext password switch does not affect the issue

The problem is that it should, since I think with nextcloud/owncloud music you have to use plaintext password auth. But, I had mistakenly left a bit of code in here that was forcing the initial server ping/feature tests when you add a new source to always use token auth instead of respecting the value of that switch.

So barring any other issues I think the build in this pull request should work if you want to try it, but I'm going to get my own instance set up for testing again before releasing another alpha to be sure if you want to wait.

https://github.com/austinried/subtracks/actions/runs/5001668335?pr=179

@Gene-W
Copy link
Author

Gene-W commented May 18, 2023

I think the build in this pull request should work

Perfect, up and running! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants