Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-format job is broken #292

Closed
chiphogg opened this issue Sep 16, 2024 · 0 comments · Fixed by #306
Closed

clang-format job is broken #292

chiphogg opened this issue Sep 16, 2024 · 0 comments · Fixed by #306

Comments

@chiphogg
Copy link
Contributor

See:

For now, we will just disable this job. I think this is a fine intermediate solution, because I am the one making most or all of the PRs, and I run clang-format automatically.

Once we decide which release we want to use, we can kick off an Aurora security review on the diff with the current version.

chiphogg added a commit that referenced this issue Sep 16, 2024
We'll need to get a known-good release through security review, and then
we can re-enable it.  Meanwhile, #292 will track this issue and remind
us that we'll need to do this.
chiphogg added a commit that referenced this issue Sep 16, 2024
We'll need to get a known-good release through security review, and then
we can re-enable it.  Meanwhile, #292 will track this issue and remind
us that we'll need to do this.

---------

Co-authored-by: Tim Hirsh <[email protected]>
chiphogg added a commit that referenced this issue Oct 22, 2024
The latest version has now been approved by an Aurora-internal security
review.

Fixes #292.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant