Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review sync method behaviour #510

Open
jamescalam opened this issue Jan 13, 2025 · 0 comments
Open

Review sync method behaviour #510

jamescalam opened this issue Jan 13, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jamescalam
Copy link
Member

jamescalam commented Jan 13, 2025

There are some cases such as force-remote and force-local that seem to be behaving slightly oddly. For example where additional routes are maintained where they should be removed, etc — we sometimes see this in the tests with the Route 3 utterance.

We must also try and remove include_metadata parameter from sync methods. This was added to handle the weird sync behaviours in the tests but was intended as a bandaid solution until a full fix is possible.

@jamescalam jamescalam self-assigned this Jan 13, 2025
@jamescalam jamescalam added the bug Something isn't working label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant