-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to latest release causes compiler errors. #118
Comments
I am getting the same. |
I have also just updated to the newest rc version and got other compile error when using ModuleConcatenationPlugin: Seems like I get this error when requesting |
Similar issues here.
Rolled back to RC2 in the meantime. |
Funny thing is I haven't had any issues with it. I mean I get the errors, but it still works fine. At least for me, everything still works as expected. |
Those errors don't impact runtime, it's just bad TS definitions apparently. Do you guys use a Typescript Or does it really come from your app compilation? If so, that's rather strange because the I notice @Miklet that's unrelated, please open another issue. Aurelia webpack plugin RC3 should have brought compatibility with |
I received a repro. It used awesome TS loader but the error went away when I switched to I'm not too familiar with |
I use at-loader. It is during the build process and not from the webpack.config file. Here is a list of my errors:
|
Another |
I can confirm using |
Is ts-loader better than at-loader? From what I've seen, at-loader is faster. Maybe that has changed. |
I was also using |
@Vheissu I'd like to try to figure out why at-loader behaves this way and if it can be fixed before changing the skeletons. |
I tried switching to ts-loader, but that just caused a bunch of other errors. Plus, ts-loader is so much slower than at-loader. |
We've just hit this in the CLI. aurelia/cli#700 (comment) is a good solution until we can figure out what's going on |
I may have some clues. The webpack typescript definition has import statements, which makes it a module: microsoft/TypeScript#5506 (comment). So you need to import it before using it. The typescript definitions of the webpack plugin doesn't do this: https://github.com/aurelia/webpack-plugin/blob/master/dist/types/AureliaPlugin.d.ts#L27-L28. This wasn't a problem until this change that adds the typings file to package.json. |
We found that removing We'll publish this work-around until a better solution is found, I opened s-panferov/awesome-typescript-loader#484. If you used those definition to build |
A few months later... clarifying the status of this open issue:
|
I'm closing this as we worked-around the issue by removing typings. #143 tracks adding them back, but I'm not sure if/when it's gonna happen, given the lack of support from awesome-typescript-loader. |
I just updated to rc3 and I'm seeing the following starting to occur in my project with the latest webpack 3 + rc3 plugin.
Is this a known issue?
The text was updated successfully, but these errors were encountered: