fix(component-tester): call detached and unbind when disposing of tested component #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martingust Can you review this real quick? |
|
@tkhyn @EisenbergEffect I think this change makes sense. Ultimately the dispose function should probably be moved out of the create method and put on class level. @tkhyn Any chance you can get that in as well, if not we can merge this and update later. Thanks! |
|
@martingust sure I'll do that tonight. I simply assumed that you wanted the |
|
Thanks @tkhyn! |
| this.host = document.createElement('div'); | ||
| this.host.innerHTML = this._html; | ||
| document.body.appendChild(this.host); | ||
| aurelia.enhance(this._bindingContext, this.host); |
There was a problem hiding this comment.
enhance returns a promise now. is this still working?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComponentTester.dispose() should also detach and unbind the view.
As calling
unbindanddetachedtwice would have no effect, there is no need to monkey-patch them in_prepareLifecycleas it's done forbindandattached.