From f1585ccab4c1f20e41d2eb1d6ba205ec39e57828 Mon Sep 17 00:00:00 2001
From: Thomas Khyn <thomas@ksytek.com>
Date: Thu, 28 Jul 2016 00:50:19 +1200
Subject: [PATCH] fix(component-tester): call detached and unbind when
 disposing of tested component (#27)

* fix(component-tester): call detached and unbind when disposing of tested component

* refactor(component-tester): convert ComponentTester.dispose into a method
---
 src/component-tester.js | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/src/component-tester.js b/src/component-tester.js
index c793ee6..999bdbb 100644
--- a/src/component-tester.js
+++ b/src/component-tester.js
@@ -11,7 +11,6 @@ export class ComponentTester {
   bind: (bindingContext: any) => void;
   attached: () => void;
   unbind: () => void;
-  dispose: () => Promise<any>;
   element: Element;
   viewModel: any;
   configure = aurelia => aurelia.use.standardConfiguration();
@@ -51,22 +50,32 @@ export class ComponentTester {
           aurelia.use.globalResources(this._resources);
         }
         return aurelia.start().then(a => {
-          let host = document.createElement('div');
-          host.innerHTML = this._html;
-          document.body.appendChild(host);
-          aurelia.enhance(this._bindingContext, host);
+          this.host = document.createElement('div');
+          this.host.innerHTML = this._html;
+          document.body.appendChild(this.host);
+          aurelia.enhance(this._bindingContext, this.host);
           this._rootView = aurelia.root;
-          this.element = host.firstElementChild;
+          this.element = this.host.firstElementChild;
           if (aurelia.root.controllers.length) {
             this.viewModel = aurelia.root.controllers[0].viewModel;
           }
-          this.dispose = () => host.parentNode.removeChild(host);
           return new Promise(resolve => setTimeout(() => resolve(), 0));
         });
       });
     });
   }
 
+  dispose() {
+    if (this.host === undefined || this._rootView === undefined) {
+        throw new Error(
+          'Cannot call ComponentTester.dispose() before ComponentTester.create()'
+        );
+    }
+    this._rootView.detached();
+    this._rootView.unbind();
+    return this.host.parentNode.removeChild(this.host);
+  }
+  
   _prepareLifecycle() {
     // bind
     const bindPrototype = View.prototype.bind;