Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.10 #67

Closed
hagenw opened this issue Jan 3, 2023 · 11 comments
Closed

Add support for Python 3.10 #67

hagenw opened this issue Jan 3, 2023 · 11 comments

Comments

@hagenw
Copy link
Member

hagenw commented Jan 3, 2023

The corresponding pull request (#66) is failing due to an error related with Artifactory and Pathlib which is most likely related to audeering/audfactory#38

@hagenw
Copy link
Member Author

hagenw commented Feb 13, 2023

Another related problem here is that we have hard-coded requirement for dohq-artifactory ==0.7.742 which means we cannot include the fix we propose for audfactory in audeering/audfactory#45.

@frankenjoe is there a possibility to make a bug fix release of audbackend or is this not possible before doing further changes? Or better: does the current main version work with audb?

@hagenw
Copy link
Member Author

hagenw commented Feb 13, 2023

We introduced the

dohq-artifactory ==0.7.742

line in #27, but I think it was an error/leftover as we fixed an issue there occuring with newer version of dohq-artifactory.
I also added dohq-artifactory >=0.8.1 in #66 and it works just fine, so I think we can simply fix this by removing the line and depend on a new version of audfactory after audeering/audfactory#45 is included there.

@frankenjoe
Copy link
Collaborator

depend on a new version of audfactory after audeering/audfactory#45 is included there.

Now that we no longer use the maven-like file structure in audbackend, which is still used by audfactory we should probably get rid of the dependency to audfactory as proposed in #50

@hagenw
Copy link
Member Author

hagenw commented Feb 13, 2023

If this is possible without much work, ok, but otherwise I would be in favor of a simple bug fix release to make audb work under Python 3.10

@frankenjoe
Copy link
Collaborator

The problem is that we cannot easily release a new version from the current master, as this changes the file structure we store files on Artifactory.

@hagenw
Copy link
Member Author

hagenw commented Feb 13, 2023

OK, I was afraid of this already ;)

But I think there is still a way. We can go back in time of the commit history before you did the changes, apply the audfactory and dohq-artifactory version fix there and create a release at this position. We can then rewrite the history of the main branch afterwards.

@hagenw
Copy link
Member Author

hagenw commented Feb 13, 2023

Or maybe we remove the new changes from main and put them into a dev branch to not have this problem again.

@frankenjoe
Copy link
Collaborator

frankenjoe commented Feb 13, 2023

Or we wait until we have a new release of audbackend, there are only a few little changes missing.

@hagenw
Copy link
Member Author

hagenw commented Feb 13, 2023

I would still prefer to first do a small bug fix release.
I created a branch dev from the current main branch. We could also select this as the default branch after we have done the bug fix release, so new pull requests will automatically compared against it. If then everything is ready we could merge it into main and make main the default branch again.

The question is how far do we need to go back in time for making the bug fix release:

92e0039 TST: remove pytest-flake from requirements (#69)  [Hagen Wierstorf] (HEAD -> dev, origin/main, origin/dev, origin/HEAD, main)
9bf8136 DOC: split up into sub-pages per class/function (#68)  [Hagen Wierstorf]
f6a157e TST: update Github Action versions (#65)  [Hagen Wierstorf]
098c862 TST: use main as default branch name (#64)  [Hagen Wierstorf]
46861fa TST: use pre-commit for flake8 checks (#63)  [Hagen Wierstorf]
2bd7d0f Reimplement Backend.ls() (#53)  [Johannes Wagner] (origin/master)
d7882d7 Add available() to list available backends (#56)  [Johannes Wagner]
3ce7c6d DOC: add docstring examples (#54)  [Johannes Wagner]
2b68ef4 do not convert . to / in url (#52)  [Johannes Wagner]
3385dea Remove Backend.path() and Backend._path() (#47)  [Johannes Wagner]
366cb20 Release v0.3.16 (#45)  [Johannes Wagner] (tag: v0.3.16)

Should we go directly to 366cb20 to be on the safe side?

@frankenjoe
Copy link
Collaborator

I guess so

@hagenw
Copy link
Member Author

hagenw commented Feb 13, 2023

Done in #66

As said I did now reqrite the history of main and set dev as the new default branch for further development. All pull requests are updated to have dev as target.

@hagenw hagenw closed this as completed Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants