Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that all media and tables are available before start upload #2

Closed
hagenw opened this issue Mar 29, 2021 · 5 comments · Fixed by #253
Closed

Check that all media and tables are available before start upload #2

hagenw opened this issue Mar 29, 2021 · 5 comments · Fixed by #253
Labels
enhancement New feature or request publish

Comments

@hagenw
Copy link
Member

hagenw commented Mar 29, 2021

Make sure we are not starting a publishing process that will fail and leave behind a corrupted database.

@hagenw hagenw added the enhancement New feature or request label Mar 29, 2021
@hagenw hagenw added the publish label May 6, 2021
@hagenw
Copy link
Member Author

hagenw commented May 11, 2021

I think this might be no longer relevant as we now support that you cancel a publishing process in between and continue afterwards. @frankenjoe: correct?

@frankenjoe
Copy link
Collaborator

frankenjoe commented May 11, 2021

I think this might be no longer relevant as we now support that you cancel a publishing process in between and continue afterwards. @frankenjoe: correct?

Yes, publish() skips files that are already on the backend, but only if the checksum matches. We need this check to verify that files have been completely uploaded. I.e. it may fail if the user does not have rights to overwrite files on the backend.

@hagenw
Copy link
Member Author

hagenw commented May 3, 2022

The original issue is solved, but we still have

I.e. it may fail if the user does not have rights to overwrite files on the backend.

This means if a user has only write permissions on the backend she can run succesfully audb.publish(), but it might fail if she does not have overwrite permissions, cancel audb.publish() in between and restart it, correct?

@hagenw
Copy link
Member Author

hagenw commented May 10, 2022

I see three solutions:

  • state in the documentation that a user needs write and overwrite permissions on the backend for publish()
  • catch the error from the backend and raise a custom error stating that overwrite permissions are needed
  • do nothing and stay with the current implementation that will simply present the error message from the backend to the user

@frankenjoe
Copy link
Collaborator

Yes, maybe we could mention in the documentation that restarting publish() after it was canceled may require overwrite permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request publish
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants