Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic controls on footnote symbols #90

Merged
merged 31 commits into from
May 24, 2023
Merged

feat: dynamic controls on footnote symbols #90

merged 31 commits into from
May 24, 2023

Conversation

atusy
Copy link
Owner

@atusy atusy commented Mar 13, 2023

todo:

  • allow prefix/suffix arguments to accept character vectors with length 2. use first one as symbols in the cell and the second one as symbols in the footnote. In this way, suffix space can be omitted from cells.
    • Description would be too complicated, while not so powerful
  • allow footnote_options(ref = function(n, part) {})
    footnote_options(ref = function(n, part) {
      ref <- `if`(part == "body", as.character(n), letters[n])
      if (footer) return(paste0(ref, ": "))
      return(ref)
    })
  • test the above behavior
  • document

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 13, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 76c554f
Status: ✅  Deploy successful!
Preview URL: https://692cd1d2.ftextra.pages.dev
Branch Preview URL: https://footnote.ftextra.pages.dev

View logs

@atusy atusy force-pushed the footnote branch 6 times, most recently from 77edf2c to f869b0c Compare March 14, 2023 06:21
@atusy atusy marked this pull request as ready for review May 24, 2023 15:19
@atusy atusy merged commit 048d413 into master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant