Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow keys stops working #1292

Closed
mindriddler opened this issue Oct 7, 2023 · 3 comments
Closed

Arrow keys stops working #1292

mindriddler opened this issue Oct 7, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@mindriddler
Copy link

mindriddler commented Oct 7, 2023

Describe the bug
When using atuin to run a python command the up and down arrows stops working inside the python code when its needed for a interactive choice. See this video

To Reproduce
Steps to reproduce the behavior:

  1. Clone this repo https://github.com/mindriddler/atuin-arrow-keys.git
  2. Create venv python -m venv venv
  3. Activate venv source venv/bin/activate
  4. Install requirements pip install -r requirements.txt
  5. Run code python main.py
  6. Try using the arrow keys
  7. If python main.py is ran directly from the terminal it should work each time until command is pulled from atuin history
  8. Try run python main.py when its pulled from atuin history
  9. Should not work anymore
  10. Use reset command or any other terminal appliation (i have tried using lazygit) to reset the shell
  11. python main.py directly from the terminal should work again

Expected behavior
I expect my arrow keys to still be working inside the python code after i pull the command from atuin history

Device (please complete the following information):

  • OS: Arch Linux
  • Shell: zsh/bash
  • Version: 16.0.0
@mindriddler mindriddler added the bug Something isn't working label Oct 7, 2023
@ellie
Copy link
Member

ellie commented Oct 17, 2023

This is resolved in main! Confirmed on macOS, with zsh, and latest Atuin from source. I suspect it's because of #1170

Happy to reopen if that is not the case. I'll be releasing v17 next week (delayed because my build machine is in my house, offline, and I'm travelling)

@ellie ellie closed this as completed Oct 17, 2023
@ellie
Copy link
Member

ellie commented Oct 17, 2023

Also thank you so much for providing such an easily replicate-able test case! Very helpful 🙏

@mindriddler
Copy link
Author

Will be waiting the release of v17 to test it out and see if it works then. But in the meantime, thank you so much for fixing the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants