update_all_ip_primal_solutions! reverse loop

[guimarqu]

Coluna.jl/src/Algorithm/utilities/optimizationstate.jl

Lines 223 to 231 in 50b2f4e

	function update_all_ip_primal_solutions!(
	dest_state::OptimizationState, orig_state::OptimizationState
	)
	# we do it in reverse order in order not to store the same solution several times
	if nb_ip_primal_sols(orig_state) > 0
	for ip_primal_sol in reverse(get_ip_primal_sols(orig_state))
	update_ip_primal_sol!(dest_state, ip_primal_sol)
	end
	end

@rrsadykov what does it change if you loop in reverse or normal mode ? I don't understand the comment.

[guimarqu]

Because you want to store all of them and if you start by the beginning you'll only store the best one ?
We should use add_ip_primal_sol! in that case.

[rrsadykov]

Yes, this is the idea: we use update_ip_primal_sol!() to store only improving solutions. Otherwise the same solution may be stored several times (orig_state is usually initialized by dest_state in the code), or we would need to compare all solutions one-by-one which takes time.
Because we use update_ip_primal_sol!(), we need to call it for new solutions in the reverse order, otherwise only the best improving solution would be stored.

[guimarqu]

Ok nice

[guimarqu]

I leave the issue open, I would like to try things later to see if we can avoid having too many extra methods to handle solutions

[guimarqu]

This method does not exist anymore.