Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad practices in tests #376

Closed
guimarqu opened this issue Jun 16, 2020 · 1 comment
Closed

Bad practices in tests #376

guimarqu opened this issue Jun 16, 2020 · 1 comment
Labels

Comments

@guimarqu
Copy link
Contributor

guimarqu commented Jun 16, 2020

In preprocessing tests, one tries to access Coluna's internal Formulations through the JuMP model to test how the preprocessing modifies elements of Formulations. I think it's a bad pratice and we should use JuMP/MOI API instead of doing :

problem.moi_backend.optimizer.inner.re_formulation.master

One could create an algorithm (in tests) that runs the preprocessing and checks the elements. The algorithm will have direct access to all Formulations.

Same for tests of show method.

@guimarqu guimarqu added the tests label Jun 16, 2020
@guimarqu guimarqu added this to the v1.0 milestone Jun 26, 2020
@guimarqu guimarqu removed this from the v1.0 milestone Dec 16, 2021
@guimarqu
Copy link
Contributor Author

Quality of tests increases. I close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant