Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not enough tests for set/get of Variables and Constraints #176

Closed
guimarqu opened this issue Aug 29, 2019 · 3 comments
Closed

Not enough tests for set/get of Variables and Constraints #176

guimarqu opened this issue Aug 29, 2019 · 3 comments
Assignees

Comments

@guimarqu
Copy link
Contributor

guimarqu commented Aug 29, 2019

setcurkind was not setting the bounds of cur_data at [0.0,1.0]. (fixed in benders branch).

We should also discuss about this behavior : EDIT (03/02/2021) : handled by MOI (cf #436 #437).

    CL.setkind!(v_data, CL.Binary)
    @test CL.getkind(v_data) == CL.Binary
    @test CL.getlb(v_data) == 0.0
    @test CL.getub(v_data) == -113.0
@guimarqu guimarqu added the tests label Aug 29, 2019
@guimarqu guimarqu added this to the v0.2 milestone Aug 29, 2019
@guimarqu guimarqu modified the milestones: v0.2, v0.3 Oct 16, 2019
@guimarqu guimarqu modified the milestones: v0.3, v0.4 Jun 1, 2020
@guimarqu
Copy link
Contributor Author

@laradicp do you think we can close this issue thanks to MOI tests ?

@laradicp
Copy link
Contributor

@laradicp do you think we can close this issue thanks to MOI tests ?

I don't know if get ConstraintDual and set ConstraintSet are considered related to this issue. If they are, maybe it could be closed after adding these two methods?

@guimarqu
Copy link
Contributor Author

Ok yes they are kind of related but it's already in the TODO lists of MOI tests. Let's close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants