Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty Conquer Strategy + NoBranching = infinite loop #166

Closed
guimarqu opened this issue Aug 12, 2019 · 2 comments
Closed

Empty Conquer Strategy + NoBranching = infinite loop #166

guimarqu opened this issue Aug 12, 2019 · 2 comments
Assignees
@vitornesello @FD-V
Labels
bug Something isn't working
Milestone
v0.2

Comments

@guimarqu
Copy link
Contributor

  • New test to reproduce the bug
  • Fix
@guimarqu guimarqu added the bug Something isn't working label Aug 12, 2019
@guimarqu
Copy link
Contributor Author

Because of reformulationsolver.jl:161

    if !to_be_pruned(n)
        @logmsg LogLevel(-1) string("Node should not be pruned. Re-inserting in the tree.")
        push!(t, n)
    else

Maybe Coluna should consider a node pruned when the conquer strategy ends ?

@vitornesello
Copy link
Collaborator

This behavior was intended. If someone defines an empty strategies he must not expect to solve something

@guimarqu guimarqu added this to the v0.2 milestone Aug 25, 2019
@FD-V FD-V modified the milestones: v0.2, v0.3 Oct 18, 2019
@guimarqu guimarqu mentioned this issue Nov 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitornesello vitornesello

@FD-V FD-V

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
3 participants
@guimarqu @vitornesello @FD-V