Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AbstractHeuristic to Algorithm module #1078

Closed
rrsadykov opened this issue Sep 26, 2023 · 2 comments · Fixed by #1120
Closed

Move AbstractHeuristic to Algorithm module #1078

rrsadykov opened this issue Sep 26, 2023 · 2 comments · Fixed by #1120
Assignees

Comments

@rrsadykov
Copy link
Collaborator

rrsadykov commented Sep 26, 2023

I cannot now define that the input of an AbstractHeuristic should be an OptimizationState because the latter is defined in the Algorithm module. I propose to remove Heuristic module (it has only 29 lines!) and put everything from there to the Algorithm module. Heuristic is (a special case of) an algorithm!

@rrsadykov rrsadykov changed the title Move AbstractHeuristic to Algoirithm module Move AbstractHeuristic to Algorithm module Sep 26, 2023
@rrsadykov
Copy link
Collaborator Author

We may even remove AbstractHeuristic to simplify things, and define each heuristic as an AbstractOptimizationAlgorithm.

@rrsadykov
Copy link
Collaborator Author

If we do these changes, they should be done after merging the continue_diving branch to the master

@rrsadykov rrsadykov linked a pull request Jan 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants