Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Show error message in tooltip when initialization fails #238

Closed
1 task done
winstliu opened this issue Nov 17, 2017 · 3 comments
Closed
1 task done

Show error message in tooltip when initialization fails #238

winstliu opened this issue Nov 17, 2017 · 3 comments

Comments

@winstliu
Copy link
Contributor

Prerequisites

  • Put an X between the brackets on this line if you have done all of the following:

Description

I don't think there's a reason to create a notification error when initialization fails because you'll always be going through the tooltip UI. Perhaps the notification was added before the tooltip existed? Either way, the tooltip should provide a copy of the error message.
teletype-initialization-failed-no-try-again-button

Steps to Reproduce

  1. Turn off the interwebs
  2. Try to start teletyping

Expected behavior: Tooltip explains what the error is

Actual behavior: Tooltip contains a generic failure message

Reproduces how often: 100%

@rvermeiren
Copy link
Contributor

Hi,
I'm a student in last year in computer science at the UCL in Belgium and I want to make my first contribution to an open source project. I choose atom/teletype as it's one of my favorite tools for collaborative work and pair programming.

Do you think it's an affordable fix for a beginner? I will work on a VM with the last LTS version of Ubuntu and use the development mode of Atom for testing my fix.

I have already read a lot of documentation on how to contribute to Atom.

I will very thankful if someone could help me if I have a problem.

Regards,

Rémy

@nathansobo
Copy link
Contributor

@rvermeiren Thanks for reaching out. I think it's worth a try. You need to understand how this package updates the contents of the tooltip and also look at where we present the notification. You'll also want to take a look at the existing tests to figure out how to add one to cover the new behavior. Good luck!

@jasonrudolph
Copy link
Contributor

Closed by #309. Thanks, @rvermeiren. 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants