-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Language Info from CLI #18
Comments
cc @zcbenz |
Any progress so far? |
Still waiting @nurtext .... If my c++ skills were better I'd fix it myself and submit a PR. Here is a simple node script that I knocked up that achieves the same thing if you're desperate: electron-userland/electron-builder#672 I agree that it would be much better to fix here though! |
Thanks @dharders, already seen the script. Curious how you implemented it in your build workflow. Any tips? Appreciate it! |
The script was more a proof of concept, called after build but before code signing. Nothing special, just used as a gulp task / npm script. That being said, I no longer use it as I'm using electron-builder with NSIS and it automatically handles it for me. However, only the installer has the correct language but the runtime still has English US, hence why I'm still waiting for this issue to be resolved. |
no news on this? |
Any progress so far? |
You can use |
By default, the language is set as English US.
For those of us that are outside of the US, is there a way to set the language from the CLI, assuming we know the language / sub_lang hex codes ?
Currently, the locale code is hardcoded in rcedit.rc
Where
0x0409 == 1033 == en_us
and1200
== 1.2.0.0 version.SetVersionString()
is only exposing the1200 part (i.e. the version) in main.cc, but there is the an extended version of the functionSetVersionString()
in rescle.cc.Please allow us to pass locale codes from CLI (in hex or decimal or en_au format doesn't matter).
If there is already a way to do this, please explain. Thanks !
The text was updated successfully, but these errors were encountered: