Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Language Info from CLI #18

Open
dharders opened this issue Jun 13, 2016 · 8 comments
Open

Set Language Info from CLI #18

dharders opened this issue Jun 13, 2016 · 8 comments

Comments

@dharders
Copy link

dharders commented Jun 13, 2016

By default, the language is set as English US.

For those of us that are outside of the US, is there a way to set the language from the CLI, assuming we know the language / sub_lang hex codes ?

Currently, the locale code is hardcoded in rcedit.rc

BLOCK "VarFileInfo"
BEGIN
    VALUE "Translation", 0x409, 1200
END

Where 0x0409 == 1033 == en_us and 1200 == 1.2.0.0 version.

SetVersionString() is only exposing the1200 part (i.e. the version) in main.cc, but there is the an extended version of the function SetVersionString() in rescle.cc.

Please allow us to pass locale codes from CLI (in hex or decimal or en_au format doesn't matter).

If there is already a way to do this, please explain. Thanks !

@dharders
Copy link
Author

cc @zcbenz

@nurtext
Copy link

nurtext commented Jan 20, 2017

Any progress so far?

@dharders
Copy link
Author

Still waiting @nurtext ....

If my c++ skills were better I'd fix it myself and submit a PR.

Here is a simple node script that I knocked up that achieves the same thing if you're desperate: electron-userland/electron-builder#672

I agree that it would be much better to fix here though!

@nurtext
Copy link

nurtext commented Jan 20, 2017

Thanks @dharders, already seen the script. Curious how you implemented it in your build workflow. Any tips? Appreciate it!

@dharders
Copy link
Author

The script was more a proof of concept, called after build but before code signing. Nothing special, just used as a gulp task / npm script.

That being said, I no longer use it as I'm using electron-builder with NSIS and it automatically handles it for me. However, only the installer has the correct language but the runtime still has English US, hence why I'm still waiting for this issue to be resolved.

@aliaga-d
Copy link

no news on this?
It seems NSIS has the option to set language but not the portable target

@tenwx
Copy link

tenwx commented Jan 10, 2022

Any progress so far?

@kanweiwei
Copy link

You can use peresed.exe to apply a new .res by Python module pe_tools before signing the .exe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants