Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Notification cover tab bar. #86

Closed
gandm opened this issue Jul 9, 2015 · 11 comments
Closed

Notification cover tab bar. #86

gandm opened this issue Jul 9, 2015 · 11 comments

Comments

@gandm
Copy link

gandm commented Jul 9, 2015

Notifications cover the tab bar making it difficult to change tabs whilst an error exists. Can notifications be placed lower down.

@emileber
Copy link

I would really like to choose from which corner the notifications can appear. Making them appear from the lower right corner would solve this issue and we could still view code since it's possible to scroll past the end of file content.

@simurai
Copy link
Contributor

simurai commented Mar 10, 2016

Not sure if/when this gets addressed, but in the meantime, you could temporarily add this to your styles.less:

atom-notifications {
    top: 50px; // move notifications down a bit
}

screen shot 2016-03-10 at 4 24 57 pm

@emileber
Copy link

Thanks @simurai

@emacstheviking
Copy link

Awesome. I should have read further before complaining!

@damieng
Copy link
Contributor

damieng commented Jan 6, 2017

@simurai Do we want to do something like this in the default themes or just have this as a workaround for people who run into it?

@emileber
Copy link

emileber commented Jan 6, 2017

I would say it should be the default, or move the notifications to the bottom.

@simurai
Copy link
Contributor

simurai commented Jan 6, 2017

Yeah, for the bundled themes we can move it down a bit. Moving to the bottom is also problematic because it will cover things like find-and-replace.

@damieng
Copy link
Contributor

damieng commented Jan 9, 2017

Fixed in 4c2b349 will ship with next beta.

@damieng damieng closed this as completed Jan 9, 2017
@simurai
Copy link
Contributor

simurai commented Jan 11, 2017

@damieng With 35px the tabs will still be covered when using a custom title bar on macOS:

screen shot 2017-01-11 at 1 40 56 pm

But maybe ok for now, since you can still click the tabs behind.

@damieng
Copy link
Contributor

damieng commented Jan 11, 2017

Yeah we can't compensate for everything a theme/person might do without restructing where notifications live in the DOM which would probably open a whole other can of worms.

@emileber
Copy link

At least it's not completely covered anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants