Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

"Unknown Windows version" when system language is not English #194

Open
winstliu opened this issue May 1, 2018 · 2 comments
Open

"Unknown Windows version" when system language is not English #194

winstliu opened this issue May 1, 2018 · 2 comments

Comments

@winstliu
Copy link
Contributor

winstliu commented May 1, 2018

The regex that looks for the Windows version in systeminfo only supports English locales. For example, my system locale is in Spanish and the output looks like Nombre del sistema operativo: Microsoft Windows 10 Home.

While it's unfortunate that Microsoft doesn't seem to provide a command that outputs machine-readable version info, we might be able to work around that by always targeting the third line of the output (which is also prone to breakage, but hopefully won't change in the near future).

@Ben3eeE
Copy link

Ben3eeE commented May 1, 2018

#159

@winstliu
Copy link
Contributor Author

winstliu commented May 1, 2018

Ah! Didn't check PRs. Thanks for finding that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants