Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Notifications should disable packages that throw "too many" unhandled exceptions #116

Open
lee-dohm opened this issue Mar 26, 2016 · 3 comments

Comments

@lee-dohm
Copy link
Contributor

Related to #103

Capturing errors is expensive. Some packages get into a bad state and start throwing more than the system can handle, bogging down the application. The notifications package should include some code that keeps track of unhandled exceptions and disables misbehaving packages. We could start with more than 1 exception per minute for 5 minutes or longer and tweak from there.

@joefitzgerald
Copy link

Rather than disable, can we just deactivate?

@lee-dohm
Copy link
Contributor Author

That's a possibility too. I didn't think too deeply on this, I just wanted to capture it 😀

@joefitzgerald
Copy link

Disabling is just a huge penalty to apply to a package author. It means that - should they release an update with a fix - it would still require manual user interaction to re-enable the package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants