Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

CompositeDisposable: add shouldn't be ignored when already disposed #49

Open
wbinnssmith opened this issue Apr 1, 2019 · 0 comments
Open

Comments

@wbinnssmith
Copy link
Contributor

It seems dangerous for a CompositeDisposable to do nothing if another disposable is added after the CompositeDisposable has been disposed.

For instance, Nuclide's UniversalDisposable immediately throws if it's been disposed of itself, and RxJS's Subscription immediately
unsubscribes from the passed subscription
.

Throwing seems like a pretty good option in my opinion as I can't think of a good reason to add to an already disposed composite disposable, but maybe there is?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants