You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Throwing seems like a pretty good option in my opinion as I can't think of a good reason to add to an already disposed composite disposable, but maybe there is?
The text was updated successfully, but these errors were encountered:
It seems dangerous for a
CompositeDisposable
to do nothing if another disposable is added after theCompositeDisposable
has been disposed.For instance, Nuclide's
UniversalDisposable
immediately throws if it's been disposed of itself, and RxJS's Subscription immediatelyunsubscribes from the passed subscription.
Throwing seems like a pretty good option in my opinion as I can't think of a good reason to add to an already disposed composite disposable, but maybe there is?
The text was updated successfully, but these errors were encountered: