-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to electron #1389
Rename to electron #1389
Conversation
Awesome! ✨
|
nice one, guys! we love it at @avocode :) |
@@ -72,7 +72,7 @@ | |||
}; | |||
</script> | |||
|
|||
<h2 style="-webkit-app-region: drag">Welcome to Atom Shell</h2> | |||
<h2 style="-webkit-app-region: drag">Welcome to Electron</h2> | |||
|
|||
<p> | |||
To run your app with atom-shell, execute the following command under your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to change it here
|
Yesssssss |
Oooh! Sounds nice! |
@YuriSolovyov Although then we'd end up with |
@mnquintana it does not have to be ARchive, it can be a PACKage, or something. |
Now that I think about it, |
@kevinsawicki are you going to design a logo too? |
I think it'd be super cool if we had as few non-breaking changes to existing code as possible just to change a marketing name, so far we're doing pretty good |
Eventually yes, a new site is being worked on as well. |
☝️ It doesn't matter what the archive format is called, .asar is fine forever. |
This. If people are super bothered, we can imagine |
Haha no worries, I was just throwing around names not-so-seriously |
Posted a reference on Discuss: https://discuss.atom.io/t/in-case-you-hadnt-heard-atom-shell-is-being-renamed-electron/16098 |
The npm instructions are removed for now, will add it back when we had electron in npm registry.
Electron icon
@zcbenz anything left to do here before shipping this? Want to add a task list to the pull request body if there are still remaining items? |
I am impressed by this diff. |
.Append("MacOS") | ||
.Append(PRODUCT_NAME " Helper"); | ||
base::FilePath frameworks_path = GetFrameworksPath(); | ||
base::FilePath helper_path = GetHeleprAppPath(frameworks_path, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo?
Been using atom-shell for a few months. Electron is an excellent name and is better for marketing. I realize that many devs don't care about this, but it affects us all whether we know it or not. The bigger the community for Electron, the better it is all for all of us. Bravo! |
💚 💜 💙 |
Github has changed the name of atom-shell to electron as per electron/electron#1389
When Atom Shell started over two years ago, its one and only consumer was the Atom editor.
And so the original Atom Shell name was just a stopgap to refer to the Chromium/Node integration pieces and the native bits for window management and OS integrations such as the clipboard, the dock, etc.
But over the last two years Atom Shell has grown and matured to become a framework that isn't just for building text editors. People are now using it to build email clients, design tools, chat clients, and video players.
It deserves a better name that decouples it from the Atom editor association and allows it to stand on its own and continue to become the easiest way to build native apps using web tech.
So the new name will be ⚡ electron ⚡ and this pull request will update all the places in the code and the docs to this new name.
/cc @atom/core @atom/non-github-maintainers