This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Adjust font size using Control key with Mouse Scroll Wheel. #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| editor.setScrollLeft(previousScrollLeft - Math.round(wheelDeltaX * @scrollSensitivity)) | ||
| event.preventDefault() unless previousScrollLeft is editor.getScrollLeft() | ||
|
|
||
| if event.ctrlKey and (process.platform isnt 'darwin') |
There was a problem hiding this comment.
Would you mind moving this to the top of this function, under line 592, and returning early after event.preventDefault() is called?
That way it minimizes the diff even further.
|
Thanks @kevinsawicki I've updated as per your comments to simplify the diff even further. |
|
Thanks for this, sorry for the delay in merging it. |
kevinsawicki
added a commit
that referenced
this pull request
Oct 15, 2014
…-fixes Adjust font size using Control key with Mouse Scroll Wheel.
This was referenced Mar 29, 2020
This was referenced Jun 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following from previous PR, to allow merging.
This Pull Request adjusts the font size when the control key is held down and scroll wheel is used.
It ignores OSX(darwin) as this platform has a conflicting accessibility feature which should not be overwritten.