Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll past end in a grammar causes the minimap to jump when moved. #456

Closed
PJB3005 opened this issue Mar 4, 2016 · 2 comments
Closed
Labels

Comments

@PJB3005
Copy link

PJB3005 commented Mar 4, 2016

Without scroll past end set enabled in the grammar:

With scroll past end enabled in the grammar:

I clicked on around the same spot both times. With scroll past end moving in the slightest causes the minimap to jump down. The code editor scrolls down too.

The size of the jump gets smaller with larger files, I assume this is because the extra space added by scroll past end is smaller relative to the file.

Tested on both default grammars (JS) and a custom one.

EDIT: I just enabled scroll past end globally in Atom, and the bug doesn't appear to happen.

@PJB3005 PJB3005 changed the title Scroll past end in a grammar causes the minimap to be offset. Scroll past end in a grammar causes the minimap to jump when moved. Mar 4, 2016
@abe33 abe33 added the bug label Mar 5, 2016
@abe33
Copy link
Contributor

abe33 commented Mar 5, 2016

Right, nice catch, I should make sure to use scoped settings when looking for this kind of thing. I'll how easy to change that behaviour.

@abe33 abe33 closed this as completed in 92a3c66 Mar 6, 2016
@abe33
Copy link
Contributor

abe33 commented Mar 6, 2016

The minimap should now handles properly scoped setting for scroll past end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants