Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjustMinimapWidthToSoftWrap does not work as intended #452

Closed
mrleblanc101 opened this issue Feb 21, 2016 · 3 comments
Closed

adjustMinimapWidthToSoftWrap does not work as intended #452

mrleblanc101 opened this issue Feb 21, 2016 · 3 comments

Comments

@mrleblanc101
Copy link

No description provided.

@abe33
Copy link
Contributor

abe33 commented Feb 22, 2016

If you want me to fix a bug, please at least describe what the problem is properly.

@abe33 abe33 closed this as completed Feb 22, 2016
@mrleblanc101
Copy link
Author

I have character width of 2px and soft wrap to 120 character
I activated adjustMinimapWidthToSoftWrap but the width of the minimap did not change
So if i have more than 60 charcter on a line, they disapear in the nether...
I think it's because adjustMinimapWidthToSoftWrap does not take into account the character width option

@mrleblanc101 mrleblanc101 changed the title adjustMinimapWidthToSoftWrap does not work adjustMinimapWidthToSoftWrap does not work as intended Feb 25, 2016
@abe33 abe33 reopened this Feb 26, 2016
@abe33
Copy link
Contributor

abe33 commented Feb 26, 2016

Ok, I see the issue now. there's a condition in the minimap to prevent it from taking more space than what it would take without the adjustMinimapWidthToSoftWrap setting enabled. For instance, in your case the minimap should take 240px based on the preferred line length, but at the same time the limit is set to 10% of the editor's width so it won't go past that limit.
Initially this features was added to make the minimap smaller, but I didn't thought that someone would want to use it to make the minimap larger.

Can you try to solution provided in #428 to increase the limit of the minimap (let say 50%) to see if it works for you, I'll see if patching see is possible.

@abe33 abe33 closed this as completed in cc7161e May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants